MAINT: add default retry rule for Armeria client in End-to-end tests #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qchea <[email protected]>
dlvenable
reviewed
Oct 6, 2021
| Clients.newClient(String.format("gproto+http://127.0.0.1:%d/", port), | ||
| TraceServiceGrpc.TraceServiceBlockingStub.class).export(request); | ||
| TraceServiceGrpc.TraceServiceBlockingStub client = Clients.builder(String.format("gproto+http://127.0.0.1:%d/", port)) | ||
| .decorator(RetryingClient.newDecorator(RetryRule.failsafe())) |
There was a problem hiding this comment.
I like this change overall!
The documentation on this wasn't clear regarding how many times it tries. Is this limited?
If we are unsure as to the number of retries, we should be sure that the test itself has a JUnit @Timeout.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, I think it is this value:
https://javadoc.io/static/com.linecorp.armeria/armeria-javadoc/1.11.0/com/linecorp/armeria/common/Flags.html#defaultMaxTotalAttempts()
It is currently defined as 10. We should be good.
dlvenable
approved these changes
Oct 6, 2021
jianghancn
pushed a commit
to jianghancn/data-prepper
that referenced
this pull request
Oct 27, 2021
…oject#375) Signed-off-by: qchea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qchea [email protected]
Description
This change is to mitigate the flaky UnprocessedRequestException found in end-to-end tests.
Issues Resolved
#366 (mitigate)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.